From 9350a0f85b2b1b361f1d118bfd3f408a7743960e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Timm=20B=C3=A4der?= Date: Sat, 3 Jun 2017 14:38:56 +0200 Subject: [PATCH] popover: Remove useless if case rect is not nullable, so stop checking if it is NULL and instead add a g_return_val_if_fail guard. --- gtk/gtkpopover.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/gtk/gtkpopover.c b/gtk/gtkpopover.c index 2f866c9d0b..84ce4e5b66 100644 --- a/gtk/gtkpopover.c +++ b/gtk/gtkpopover.c @@ -2121,16 +2121,14 @@ gtk_popover_get_pointing_to (GtkPopover *popover, GtkPopoverPrivate *priv = gtk_popover_get_instance_private (popover); g_return_val_if_fail (GTK_IS_POPOVER (popover), FALSE); + g_return_val_if_fail (rect != NULL, FALSE); - if (rect) + if (priv->has_pointing_to) + *rect = priv->pointing_to; + else if (priv->widget) { - if (priv->has_pointing_to) - *rect = priv->pointing_to; - else if (priv->widget) - { - gtk_widget_get_allocation (priv->widget, rect); - rect->x = rect->y = 0; - } + gtk_widget_get_allocation (priv->widget, rect); + rect->x = rect->y = 0; } return priv->has_pointing_to; -- 2.30.2